Update golang.org/x/sys to fix windows compilation #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
requested review from
errm,
timoreimann,
SantoDE,
emilevauge and
dtomcej
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
fix-master-windows-compilation
branch
from
dd15dc7
to
b02b11a
Compare
timoreimann
approved these changes
Apr 17, 2017
emilevauge
approved these changes
Apr 17, 2017
There was a problem hiding this comment.
Thanks @vdemeester for fixing master.
Same as @timoreimann, don't like the fact of pinning yet another dep. But meh :/
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make
mastergreen again 👼Signed-off-by: Vincent Demeester [email protected]