Extract some code in packages #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
requested review from
errm,
timoreimann,
SantoDE,
Russell-IO,
emilevauge and
dtomcej
|
I think you'll need to adjust the Makefile targets and Docs in |
|
Hmm, given that the build ran for quite a while (even though erroneously), my comment might be false. Maybe you can double check. |
vdemeester
force-pushed
the
more-extraction
branch
from
a45abd6
to
d2cfaf0
Compare
|
@timoreimann yep, I need to update docs, just want to make sure these changes are ok for @emilevauge and everybody before doing it 👼 |
SantoDE
approved these changes
Apr 18, 2017
|
@vdemeester Looks very good to me ( love the new |
vdemeester
force-pushed
the
more-extraction
branch
2 times, most recently
from
b5a7444
to
526fc45
Compare
|
Updated with the docs 👼 |
- This will help split stuff in smaller, better tested packages - This moves some stuff like the traefik command to package `cmd` Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
more-extraction
branch
from
526fc45
to
7fcb7b8
Compare
emilevauge
approved these changes
Apr 20, 2017
ldez
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving #1006 👼
cmdIt's build on top of #1444, so only the 2nd commit should be reviewed 👼
🦁