Improve documentation for frontend rules. #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
requested review from
vdemeester,
trecloux,
errm,
SantoDE,
Russell-IO,
ldez,
emilevauge and
dtomcej
timoreimann
force-pushed
the
improve-frontend-rule-documentation
branch
6 times, most recently
from
c160a0f
to
4e004d9
Compare
|
Hands down, this is way better... For some reason I always thought that if you want to strip the path from a request, you need to include the non-strip part beforehand. Like the strip-directives ONLY strip and the other directives ONLY do the matching... Does that even makes sense? :-) Anyway, the static content serving I was struggling with is a thing of the past. Thanks a lot guys! Much appreciated! |
7imbrook
reviewed
Apr 20, 2017
|
|
||
| Use `Path` if your backend listens on the exact path only. For instance, `Path: /products` would match `/products` but not `/products/shoes`. | ||
|
|
||
| Use a `*Prefix*` matcher if your backend listens on a particular base path but also serves requests on sub-paths. For instance, `PathPrefix: /products` would match `/products` but also `/products/shoes` and `/products/shirts`. Since the path is forwarded as-is, your backend is expected to listen on `/products`. |
There was a problem hiding this comment.
I want to plus one this as REALLY helpful because it wasn't clear in the prior docs
emilevauge
approved these changes
Apr 20, 2017
Includes guidelines on proper usage of the more complex path matchers.
timoreimann
force-pushed
the
improve-frontend-rule-documentation
branch
from
4e004d9
to
051f0c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes guidelines on proper usage of the more complex path matchers.
Fixes #1411.
/cc @chmod666org @bfqrst