Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Vendor generated file" #1534

Merged
merged 1 commit into from
May 3, 2017
Merged

Revert "Vendor generated file" #1534

merged 1 commit into from
May 3, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented May 3, 2017 •
edited
Loading

Reverts #1464

Problems:

  • WebUI missing.
  • diff don't really work as expected.

vdemeester
vdemeester approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just revert 1b85dd0 though ?

Anyway, LGTM 😭

@timoreimann
Copy link
Contributor

Yeah just that commit seems enough. We should keep the shebang changes.

@ldez ldez force-pushed the revert-1464-vendor-autogen branch from 25058f2 to acb0492 Compare May 3, 2017 08:02
@ldez
Copy link
Contributor Author

ldez commented May 3, 2017

Done!

timoreimann
timoreimann approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. 👍

@timoreimann
Copy link
Contributor

A minor thing: Could we add a short description on the PR on why we needed to revert this?

This will make the decision more transparent.

@ldez ldez added the kind/bug/fix a bug fix label May 3, 2017
@ldez ldez modified the milestone: 1.3 May 3, 2017
@ldez ldez merged commit bd6056c into master May 3, 2017
@ldez ldez deleted the revert-1464-vendor-autogen branch May 3, 2017 08:40
@ldez ldez mentioned this pull request Nov 20, 2017
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann approved these changes

@vdemeester vdemeester vdemeester approved these changes

@emilevauge emilevauge Awaiting requested review from emilevauge

Assignees
No one assigned
Labels
kind/bug/fix a bug fix
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ldez @timoreimann @vdemeester