Working UI #1542
Working UI #1542
Conversation
| angular | ||
| .module(traefikCoreProvider, ['ngResource']) | ||
| .factory('Providers', Providers); | ||
| angular.module(traefikCoreProvider, ['ngResource']).factory('Providers', Providers); |
There was a problem hiding this comment.
please restore the initial code format.
There was a problem hiding this comment.
Sure, my fault. I may have auto-format too quickly.
webui/conf/browsersync.conf.js
Outdated
| @@ -1,11 +1,26 @@ | |||
| const conf = require('./gulp.conf'); | |||
| const proxy = require('http-proxy-middleware'); | |||
There was a problem hiding this comment.
could you explains/remove this dependency ?
There was a problem hiding this comment.
This dependency allows you to run in dev mode with a real Traefik backend running on localhost:8080.
For instance, when you run :
docker run -p 8080:8080 -p 80:80 -v /var/run/docker.sock:/var/run/docker.sock traefik --debug --web --docker --docker.watch
and then
npm run serve
On http://localhost:3000/ , the server is now able to connect to the running traefik /api and /health endpoints.
I think it could be useful for testing with a real server, and since it is in dev dependencies, it is not bundled in the final release. Let me know if you want me to remove this.
There was a problem hiding this comment.
Please remove this part for now, and create an other PR for this. thanks.
|
|
||
| return rawProviders; | ||
| get: function() { | ||
| return $q((resolve, reject) => { |
There was a problem hiding this comment.
$q is the preferred way to handle promises with AngularJS (1.X) , since it wraps the promise mechanism into a $digest loop, which allows immediate view refresh. For instance, notice how it takes 2 additional seconds to display data on startup, before it effectively does the $interval call that effectively refreshes data.
|
I just pushed the style correction, plus changed a test to a cleaner one that keeps displaying providers even if there are no backend registered to that provider. I'd be please to contribute by migrating to an Angular, React or VueJS front-end if I have time and you are up to, with unit tests (sorry, haven't add time to add this in this PR since there wasn't any originally, and I just wanted to make the UI work again...). Let me know. |
|
If you want migrate to Angular or VueJS, we will be very happy 😃 . (And create a new PR for this: one PR, one subject. 😉 ) |
chore(Build) : Add Babel for build. chore(Babel) : Add babel configuration. style(Code) : Enhance code style.
In case you're interested, here is the corrected/working version of the UI compared to the current state on master.
Things I did: