Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Health UI fixes #1651

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Minor Health UI fixes #1651

merged 1 commit into from
Jun 6, 2017

Conversation

mihaitodor
Copy link
Contributor

@mihaitodor mihaitodor commented May 22, 2017

  • format the Oy axis ticks as integers on the Total Status Code Count chart
  • prevent the Average Response Time chart from showing negative values on the Oy axis
  • remove the deprecated transitionDuration field
  • set the transition duration to 0 on the Average Response Time chart to avoid triggering an NVD3 marker placement bug

Here is some background on transitionDuration: https://stackoverflow.com/questions/30455485/transitionduration-function-does-not-exist-in-nvd3-js

These are some issues that I noticed while developing #1650 and I thought you guys might want to have them fixed. Please note that I'm not much of a web developer, so I hope I got them right :)

@ldez ldez added area/webui kind/enhancement a new or improved feature. labels May 22, 2017
@ldez ldez added this to the 1.4 milestone May 22, 2017
@ldez ldez self-requested a review May 23, 2017 10:08
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍
LGTM

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mihaitodor
LGTM

- format the Oy axis ticks as integers on the Total Status Code
Count chart
- prevent the Average Response Time chart from showing negative
values on the Oy axis
- remove the deprecated transitionDuration field
- set the transition duration to 0 on the Average Response Time
chart to avoid triggering an NVD3 marker placement bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webui kind/enhancement a new or improved feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants