Update CONTRIBUTING.md. #1667
Merged
Update CONTRIBUTING.md. #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
commented
May 24, 2017
.github/CONTRIBUTING.md
Outdated
| @@ -64,7 +64,7 @@ $ ( cd integration && ../script/glide.sh get github.com/baz/quuz ) | |||
| # generate (Only required to integrate other components such as web dashboard) | |||
| $ go generate | |||
| # Standard go build | |||
| $ go build | |||
| $ go build ./cmd/traefik | |||
| # Using gox to build multiple platform | |||
| $ gox "linux darwin" "386 amd64 arm" \ | |||
There was a problem hiding this comment.
I'm wondering if we should kick this one out. Personally, I've never used it, but maybe it's just me...
There was a problem hiding this comment.
yeah, I agree too. We don't use gox anymore.
There was a problem hiding this comment.
Alright, removed.
timoreimann
force-pushed
the
update-contributing-md
branch
from
d458ede
to
50d116c
Compare
- Go 1.8 is the current minimum requirement. - The main binary moved to cmd/traefik. - Remove obsolete gox example.
timoreimann
force-pushed
the
update-contributing-md
branch
from
50d116c
to
d742ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd/traefik.