Enhance rules tests. #1679
Merged
Enhance rules tests. #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/rules
kind/enhancement
timoreimann
suggested changes
May 30, 2017
| @@ -16,7 +16,7 @@ BIND_DIR := "dist" | |||
| TRAEFIK_MOUNT := -v "$(CURDIR)/$(BIND_DIR):/go/src/github.com/containous/traefik/$(BIND_DIR)" | |||
|
|
|||
| GIT_BRANCH := $(subst heads/,,$(shell git rev-parse --abbrev-ref HEAD 2>/dev/null)) | |||
| TRAEFIK_DEV_IMAGE := traefik-dev$(if $(GIT_BRANCH),:$(GIT_BRANCH)) | |||
| TRAEFIK_DEV_IMAGE := traefik-dev$(if $(GIT_BRANCH),:$(subst /,-,$(GIT_BRANCH))) | |||
There was a problem hiding this comment.
Nice, this one has bothered me before!
middlewares/replace_path_test.go
Outdated
| if oldPath != path { | ||
| t.Fatalf("old path should be '%s'", path) | ||
| } | ||
| assert.Equal(t, replacementPath, expectedPath, "%s: unexpected path.", path) |
There was a problem hiding this comment.
Expected must go before actual or otherwise the labeling will be wrong in assert.Equal's output.
middlewares/stripPrefixRegex_test.go
Outdated
| t.Errorf("Expected '%s' : '%s'\n", test.expectedResponse, response) | ||
| } | ||
| test := test | ||
| t.Run(test.desc, func(t *testing.T) { |
There was a problem hiding this comment.
For the test cases at hand, it would also suffice to pass path to t.Run as it's disambiguating already, and the descriptions aren't overly -- descriptive. :)
ldez
force-pushed
the
refactor/enhance-rules-tests
branch
from
a6c1a0d
to
1328bdb
Compare
|
@timoreimann It's fixed! |
timoreimann
approved these changes
May 31, 2017
- refactor: change incorrect package. - refactor: test readability.
ldez
force-pushed
the
refactor/enhance-rules-tests
branch
from
72ffc48
to
9ac43e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Homogenization of the tests.
The naming of cases is not perfect for
stripPrefixRegex_testbut it is more maintainable.Use
r.Header.Add("MY-HEADER", value)instead ofr.Header["MY-HEADER"] = []string{value}.Bonus:
/likefoo/bar.