Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capitalization of PathPrefixStrip in kubernetes doc #1695

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Fix capitalization of PathPrefixStrip in kubernetes doc #1695

merged 1 commit into from
Jun 1, 2017

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Jun 1, 2017

Description

This changes the doc and example from pathprefixstrip to PathPrefixStrip.

With v1.3 pathprefixstrip does not work, with the following error:

time="2017-06-01T11:46:32Z" level=error msg="Error creating route for frontend cheeses.minikube/wensleydale: Error parsing rule: Error parsing rule: 'pathprefixstrip:/wensleydale'. Unknown function: 'pathprefixstrip'" 
time="2017-06-01T11:46:32Z" level=error msg="Skipping frontend cheeses.minikube/wensleydale..."

timoreimann
timoreimann approved these changes Jun 1, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM.

@timoreimann
Copy link
Contributor

Note to reviewers: this was implicitly changed through #1630 where we removed the custom rules list from the k8s provider. While the change of behavior represents a bit of a breaking change, I think there's too little value in holding on to the lower case variants.

dtomcej
dtomcej approved these changes Jun 1, 2017
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

vdemeester
vdemeester approved these changes Jun 1, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@ldez ldez force-pushed the doc-capitalize-pathprefixstrip branch from be9b804 to 9ab8cd8 Compare June 1, 2017 17:24
@ldez ldez changed the base branch from master to v1.3 June 1, 2017 17:30
@ldez ldez force-pushed the doc-capitalize-pathprefixstrip branch from 9ab8cd8 to d958a27 Compare June 1, 2017 17:31
@ldez ldez merged commit 1db22a6 into traefik:v1.3 Jun 1, 2017
@ldez ldez added this to the 1.3 milestone Jun 1, 2017
@Miouge1 Miouge1 deleted the doc-capitalize-pathprefixstrip branch June 1, 2017 19:35
@timoreimann timoreimann mentioned this pull request Jun 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@timoreimann timoreimann timoreimann approved these changes

@dtomcej dtomcej dtomcej approved these changes

@errm errm Awaiting requested review from errm

@emilevauge emilevauge Awaiting requested review from emilevauge

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Miouge1 @timoreimann @vdemeester @dtomcej @ldez