Handle RootCAs certificate #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
force-pushed
the
feature/rootcas
branch
5 times, most recently
from
25e4c40
to
029f487
Compare
ldez
added
area/tls
kind/enhancement
ldez
suggested changes
Jun 27, 2017
server/configuration.go
Outdated
|
|
||
| // String is the method to format the flag's value, part of the flag.Value interface. | ||
| // The String method's output will be used in diagnostics. | ||
| func (dep *RootCAs) String() string { |
server/configuration.go
Outdated
| // Set is the method to set the flag value, part of the flag.Value interface. | ||
| // Set's argument is a string to be parsed to set the flag. | ||
| // It's a comma-separated list, so we split it. | ||
| func (dep *RootCAs) Set(value string) error { |
server/configuration.go
Outdated
| } | ||
|
|
||
| // Get return the EntryPoints map | ||
| func (dep *RootCAs) Get() interface{} { |
server/configuration.go
Outdated
| } | ||
|
|
||
| // SetValue sets the EntryPoints map with val | ||
| func (dep *RootCAs) SetValue(val interface{}) { |
server/configuration.go
Outdated
| } | ||
|
|
||
| // Type is type of the struct | ||
| func (dep *RootCAs) Type() string { |
integration/https_test.go
Outdated
| err = try.GetRequest("http://127.0.0.1:8081/ping", 1000*time.Millisecond, try.StatusCodeIs(http.StatusOK)) | ||
|
|
||
| c.Assert(err, checker.IsNil) | ||
|
|
server/configuration.go
Outdated
| func (dep *RootCAs) String() string { | ||
| sliceOfString := make([]string, len([]FileOrContent(*dep))) | ||
| for key, value := range *dep { | ||
| sliceOfString[key] = string(value) |
There was a problem hiding this comment.
FileOrContent need to implement Stringer instead of string(foc)
server/configuration.go
Outdated
| func (f FileOrContent) Read() ([]byte, error) { | ||
| var content []byte | ||
| if _, err := os.Stat(string(f)); err == nil { | ||
| content, err = ioutil.ReadFile(string(f)) |
There was a problem hiding this comment.
FileOrContent need to implement Stringer instead of string(foc)
integration/https_test.go
Outdated
| c.Assert(err, checker.IsNil) | ||
|
|
||
| err = try.GetRequest("http://127.0.0.1:8081/ping", 1000*time.Millisecond, try.StatusCodeIs(http.StatusOK)) | ||
|
|
integration/https_test.go
Outdated
| c.Assert(err, checker.IsNil) | ||
|
|
||
| err = try.GetRequest("http://127.0.0.1:8081/ping", 1000*time.Millisecond, try.StatusCodeIs(http.StatusOK)) | ||
|
|
emilevauge
reviewed
Jun 30, 2017
| for _, cert := range globalConfiguration.RootCAs { | ||
| certContent, err := cert.Read() | ||
| if err != nil { | ||
| log.Error("Error while read RootCAs", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to configure self-signed certificate for tls communication with the backends