Upgrade go-marathon to dd6cbd4. #1800
Conversation
|
Missed to update one transitive dep. Doing that now... |
timoreimann
force-pushed
the
upgrade-go-marathon-to-dd6cbd4
branch
from
e94e34f
to
dc6882f
Compare
| @@ -93,7 +93,6 @@ import: | |||
| - package: k8s.io/client-go | |||
| version: v2.0.0 | |||
| - package: github.com/gambol99/go-marathon | |||
| version: d672c6fbb499596869d95146a26e7d0746c06c54 | |||
There was a problem hiding this comment.
please add the hash instead remove it
There was a problem hiding this comment.
if you don't do that you produce side effect when other dependencies are added.
I have spend a lot of time to fix the lock and the yml to be stable.
There was a problem hiding this comment.
Not sure I understand... why do we need the hash with go-marathon in the glide manifest file when we don't specify one with the vast majority of other dependencies?
Semantically, we shouldn't have to add it as we are not after a specific version: When we upgrade go-marathon, we tend to look for the latest.
There was a problem hiding this comment.
It's hard to explain, sorry if I will misspoke.
Currently when you add a dependency, you don't need to pin version to yml (as we did before)
Glide do some "random" update when some version are not fixed.
I don't know exactly why, but I know Glide love the past and not the present...
Some dependencies don't update when you add a dependency but not all...
To be "safe", some dependencies must be fixed. (IMHO in the yml all dependencies must be fixed on version or hash)
I know this is not prefect but I don't want to do again +8 hours of hash analysis.
There was a problem hiding this comment.
Sure, understood. FWIW, a number of glide problems can be resolved by clearing the cache up-front (i.e., running glide cc); but I know from experience that it doesn't always help.
I updated the YML file and hash. Hope it's okay now.
Fixes a problem with UnreachableStrategy being available now in two type-incompatible formats (object and string). We also upgrade the transitive dependency github.com/donovanhide/eventsource.
timoreimann
force-pushed
the
upgrade-go-marathon-to-dd6cbd4
branch
from
44e8d99
to
dcedb26
Compare
Fixes a problem with
UnreachableStrategybeing available now in two type-incompatible formats (object and string).Fixes #1743.