Add helloworld tests with gRPC #1845
Conversation
| @@ -0,0 +1,31 @@ | |||
| logLevel = "DEBUG" | |||
| [frontends.frontend1] | ||
| backend = "backend1" | ||
| [frontends.frontend1.routes.test_1] | ||
| rule = "Host:127.0.0.1" |
integration/grpc_test.go
Outdated
| } | ||
|
|
||
| func startGrpcServer() error { | ||
| lis, err := net.Listen("tcp", ":50051") |
There was a problem hiding this comment.
Could we possibly pick a random port to avoid potential flakiness in the future?
integration/grpc_test.go
Outdated
| return "", err | ||
| } | ||
|
|
||
| //defer conn.Close() |
There was a problem hiding this comment.
Should either comment in or remove.
integration/grpc_test.go
Outdated
|
|
||
| func (s *myserver) SayHello(ctx context.Context, in *helloworld.HelloRequest) (*helloworld.HelloReply, error) { | ||
| return &helloworld.HelloReply{Message: "Hello " + in.Name}, nil | ||
|
|
integration/grpc_test.go
Outdated
|
|
||
| type myserver struct{} | ||
|
|
||
| func (s *myserver) SayHello(ctx context.Context, in *helloworld.HelloRequest) (*helloworld.HelloReply, error) { |
There was a problem hiding this comment.
ctx is not used in this function.
There was a problem hiding this comment.
Does the method need to be exported?
There was a problem hiding this comment.
The method never returns a non-nil error. Can we drop the second return parameter?
There was a problem hiding this comment.
Overall, do we need this method? :-)
There was a problem hiding this comment.
I need to implement GreeterServer
integration/grpc_test.go
Outdated
| roots := x509.NewCertPool() | ||
| roots.AppendCertsFromPEM(LocalhostCert) | ||
| credsClient := credentials.NewClientTLSFromCert(roots, "") | ||
| conn, err := grpc.Dial("127.0.0.1:4443", grpc.WithTransportCredentials(credsClient)) |
There was a problem hiding this comment.
Where does 4443 come from? The server runs on a different port, doesn't it?
There was a problem hiding this comment.
This is the traefik port
| serverOption := grpc.Creds(creds) | ||
|
|
||
| var s *grpc.Server = grpc.NewServer(serverOption) | ||
| defer s.Stop() |
There was a problem hiding this comment.
Does it make sense to defer-stop here? Don't we need the server to continue running past the the return of this method?
There was a problem hiding this comment.
s.Serve at the end of this method will block so it make sense
integration/grpc_test.go
Outdated
| err = try.GetRequest("http://127.0.0.1:8080/api/providers", 1000*time.Millisecond, try.BodyContains("Host:127.0.0.1")) | ||
| c.Assert(err, check.IsNil) | ||
|
|
||
| response, err := callHelloClientGrpc() |
There was a problem hiding this comment.
What happens if the server takes longer to boot and we fire out the request prior to it being ready? Does gRPC has some kind of retry built in?
Possibly even better: can we synchronize the start of the server with the execution of the test?
|
👍 Last question: What's the number suffix in |
|
@timoreimann |
integration/grpc_test.go
Outdated
| "google.golang.org/grpc/credentials" | ||
| ) | ||
|
|
||
| var LocalhostCert = []byte(`-----BEGIN CERTIFICATE----- |
There was a problem hiding this comment.
Can we not re-use any of the other integration test certificates, instead of hard coding another here?
There was a problem hiding this comment.
I didn't find any cert on 127.0.0.1. And I really need a local cert for contacting backend on 127.0.0.1 in a secure way.
May be I can put all the certs in a shared directory for futur reuse ? @dtomcej WDYT ?
There was a problem hiding this comment.
I think having all certs in a shared directory would be beneficial. This would prevent having to have people generate certs, and we could have wildcard certs/single host certs/ etc all in one easy to use convenient place for testing.
|
@dtomcej oups, I really need to update my global gitignore |
|
Sorry for the delay in review! LGTM! |
This PR add an integration test in order to test a simple grpc helloworld with traefik.
Grpc use http2 protocol and as we use an http reverse proxy, and that golang supports only http2 on https, we can't use directly the code from the helloworld of grpc, we need to start a server with tls certificate.