Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replace path rule #1859

Merged
merged 2 commits into from
Jul 19, 2017
Merged

Fix replace path rule #1859

merged 2 commits into from
Jul 19, 2017

Conversation

dedalusj
Copy link
Contributor

Description

Fixes #1775.

The path replace middleware wasn't setting the http.Request.RequestURI which is used by oxy.forward to compose the outgoing URL and from the point of view of the backend the path was never replaced.

Other middlewares, like addPrefix and stripPrefix, do the same thing.

@ldez ldez added this to the 1.4 milestone Jul 12, 2017
@ldez ldez added the kind/bug/fix a bug fix label Jul 12, 2017
ldez
ldez approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I have modified the tests 😉

emilevauge
emilevauge approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dedalusj
LGTM

nmengin
nmengin approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@ldez ldez changed the base branch from master to v1.3 July 18, 2017 15:36
@ldez ldez modified the milestones: 1.3, 1.4 Jul 18, 2017
@ldez ldez merged commit a09a8b1 into traefik:v1.3 Jul 19, 2017
@ldez ldez mentioned this pull request Jul 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@emilevauge emilevauge emilevauge approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@dedalusj @ldez @emilevauge @nmengin