Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace go routine by Safe.Go #1879

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Replace go routine by Safe.Go #1879

merged 1 commit into from
Jul 20, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jul 19, 2017

Description

Add Safe.Go(...) everywhere is needing.

@ldez ldez added this to the 1.4 milestone Jul 19, 2017
dtomcej
dtomcej approved these changes Jul 19, 2017
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safety First.

LGTM

:shipit:

juliens
juliens approved these changes Jul 20, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jul 20, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit c36e0b3 into traefik:master Jul 20, 2017
@ldez ldez deleted the refactor/goroutine-safe branch July 20, 2017 12:59
@ldez ldez changed the title replace go routine by Safe.Go Replace go routine by Safe.Go Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@nmengin nmengin nmengin approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ldez @juliens @nmengin @dtomcej