Add secrets resource to in-line RBAC spec. #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only existed in the Github-hosted example file.
|
@dtomcej you mean when we reverted #1798 through #1828? That's fairly unrelated as we only undid waiting for the secrets store to become populated (which would never happen in case RBAC access to Secrets wasn't set up). We still need people to grant access to secrets to guarantee basic auth works. #1784 should drive watching for secrets more selectively. Does that answer your question? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only existed in the Github-hosted example file.
Fixes an oversight from #1707.