Use default frontend priority of zero. #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
area/provider/k8s/ingress
kind/bug/fix
timoreimann
force-pushed
the
k8s-use-default-frontend-priority-of-zero
branch
from
ff0b093
to
f072b5f
Compare
timoreimann
changed the title
timoreimann
added
status/3-needs-merge
status/2-needs-review
and removed
status/2-needs-review
status/3-needs-merge
labels
traefiker
force-pushed
the
k8s-use-default-frontend-priority-of-zero
branch
from
f072b5f
to
9931b9c
Compare
|
Conventionally all providers should return a priority of zero if no override is given. The server package will then compute the priority based on the specified rules (i.e., path and host components). The Kubernetes provider diverges and returns the path length as default value explicitly. This change removes the custom behavior. As a side refactoring, we change the tests to stop comparing JSON values which are prone to subtle but non-visible differences (namely, nil and empty properties are not reflected). Instead, we use assert.Equal which also does a better job at showing a readable diff.
traefiker
force-pushed
the
k8s-use-default-frontend-priority-of-zero
branch
from
9931b9c
to
169343d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conventionally all providers should return a priority of zero if no override is given. The server package will then compute the priority based on the specified rules (i.e., path and host components). See also here and here in the server package.
The Kubernetes provider diverges and returns the path length as default value explicitly. This change removes the custom behavior.
As a side refactoring, we change the tests to stop comparing JSON values which are prone to subtle but non-visible differences (namely, nil and empty properties are not reflected). Instead, we use
assert.Equalwhich also does a better job at showing a readable diff.k8s maintainers and @containous/traefik: PTAL.