Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed by default feature in Consul Catalog #2006

Merged
merged 6 commits into from
Aug 25, 2017

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Aug 25, 2017

Description

Add feature to control in consul service catalog if services are exposed by default or not.

exposedByDefault = true|false

Fixes #854

@ldez ldez changed the title [consul-catalog] exposed by default feature Exposed by default feature in Consul Catalog Aug 25, 2017
@ldez ldez modified the milestone: 1.5 Aug 25, 2017
@emilevauge emilevauge modified the milestones: 1.4, 1.5 Aug 25, 2017
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmatur, great job!
LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the consul-catalog-exposed-by-default branch from a58d5aa to 64e1a3f Compare August 25, 2017 15:04
@traefiker traefiker merged commit f16219f into traefik:master Aug 25, 2017
@ldez ldez added the kind/enhancement a new or improved feature. label Aug 28, 2017
@mmatur mmatur deleted the consul-catalog-exposed-by-default branch March 21, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants