Update golang version in contributing guide #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/documentation
status/2-needs-review
and removed
status/0-needs-triage
labels
ldez
changed the title
timoreimann
approved these changes
Aug 28, 2017
ldez
suggested changes
Aug 28, 2017
cmd/traefik/traefik.go
Outdated
| @@ -175,7 +175,6 @@ Complete documentation is available at https://traefik.io`, | |||
| } | |||
|
|
|||
| if _, err := f.Parse(usedCmd); err != nil { | |||
| fmtlog.Printf("Error parsing command: %s\n", err) | |||
emilevauge
approved these changes
Aug 28, 2017
There was a problem hiding this comment.
Thanks @arikachen !
I reverted the commit 26919fb59b1ced386d6d65aacc8316967b36289f fix error log while execute help cmd as it introduced a regression.
LGTM
Signed-off-by: Arika Chen <[email protected]>
Signed-off-by: Arika Chen <[email protected]>
This reverts commit 26919fb59b1ced386d6d65aacc8316967b36289f.
|
ok. I made a mistake. The second path is used to fix error log when execute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arika Chen [email protected]
Description
Update golang version to 1.9 while using
Server.ServeTLSEdit by @emilevauge: The initial PR that moves to Go 1.9 is #2004.
The current PR updates the contributing documentation.