Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid service yaml example #2059

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Fix invalid service yaml example #2059

merged 1 commit into from
Sep 5, 2017

Conversation

kairen
Copy link

@kairen kairen commented Sep 5, 2017

Fixes issue #2058.

@kairen kairen requested a review from a team as a code owner September 5, 2017 04:44
timoreimann
timoreimann approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

juliens
juliens approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kairen kairen requested review from a team as code owners September 5, 2017 09:22
@ldez ldez changed the base branch from master to v1.4 September 5, 2017 09:25
@ldez ldez added this to the 1.4 milestone Sep 5, 2017
@traefiker traefiker merged commit 732d73d into traefik:v1.4 Sep 5, 2017
@timoreimann timoreimann mentioned this pull request Sep 5, 2017
Closed
@ldez ldez changed the title [Docs] Fix invalid service yaml example Fix invalid service yaml example Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@timoreimann timoreimann timoreimann approved these changes

@ldez ldez ldez approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@kairen @juliens @timoreimann @ldez @traefiker