Enable loss less rotation of log files #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could change the base branch of the PR to 1.4? |
ldez
added
kind/bug/fix
m3co-code
force-pushed
the
lossless-log-file-rotation
branch
from
855bb2c
to
46b4f5b
Compare
|
Rebased and changed the base branch of the PR. |
vdemeester
approved these changes
Sep 5, 2017
emilevauge
previously approved these changes
Sep 15, 2017
For the traefik logs this is accomplished by opening the new log file before closing the previous one. The traefik logs use the global logrus instance and it is already protected by a mutex on rotation. For the access logs such a mutex also had to be introduced.
traefiker
force-pushed
the
lossless-log-file-rotation
branch
from
46b4f5b
to
5eafa55
Compare
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is the chance that Traefik looses log lines for requests during rotation of the log file. This is at the moment true for the traefik log file as well as the access log files. I added two unit tests to prove this. This was also responsible for one flaky behaviour in the integration test here.
For the traefik logs this is accomplished by opening the new log file before closing the previous one. The traefik logs use the global
logrusinstance and it is already protected by a mutex on rotation. For the access logs such a mutex also had to be introduced.I think there is some potential in refactoring and aligning the two logging implementations in order to avoid duplicate code when it comes to the file handling and the logrus configuration. I will do this in a follow-up PR.