Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for SSL TERMINATION in Websocket IT #2063

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Add test for SSL TERMINATION in Websocket IT #2063

merged 1 commit into from
Sep 6, 2017

Conversation

juliens
Copy link
Member

@juliens juliens commented Sep 5, 2017

related to #1951

@ldez ldez added this to the 1.4 milestone Sep 5, 2017
ldez
ldez approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliens juliens changed the base branch from master to v1.4 September 5, 2017 15:20
m3co-code
m3co-code approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@m3co-code m3co-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

nmengin
nmengin approved these changes Sep 6, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 03ba839 into traefik:v1.4 Sep 6, 2017
@juliens juliens mentioned this pull request Sep 6, 2017
Closed
@ldez ldez changed the title Add test for SSL TERMINATION in Websocket Add test for SSL TERMINATION in Websocket IT Sep 8, 2017
@juliens juliens deleted the bugfix/ws-ssl-terminate branch September 13, 2017 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@m3co-code m3co-code m3co-code approved these changes

Assignees
No one assigned
Labels
area/websocket kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@juliens @m3co-code @ldez @nmengin @traefiker