Document custom error page restrictions. #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
area/documentation
kind/enhancement
timoreimann
force-pushed
the
document-custom-error-pages-restrictions
branch
from
84274e5
to
ae037f0
Compare
ldez
suggested changes
Sep 11, 2017
docs/configuration/commons.md
Outdated
| @@ -242,6 +242,8 @@ Instead, the query parameter can also be set to some generic error page like so: | |||
| Now the `500s.html` error page is returned for the configured code range. | |||
| The configured status code ranges are inclusive; that is, in the above example, the `500s.html` page will be returned for status codes `500` through, and including, `599`. | |||
|
|
|||
| Custom error pages are easiest to implement using the file provider or one of the supported K/V stores. For other dynamic providers, the corresponding template file needs to be customized accordingly and referenced in the Traefik configuration. | |||
There was a problem hiding this comment.
Could you add one sentence by line?
timoreimann
force-pushed
the
document-custom-error-pages-restrictions
branch
2 times, most recently
from
98cbb3d
to
aa4c929
Compare
|
In fact, all the k/v store use kv provider ex. https://github.com/containous/traefik/blob/master/provider/etcd/etcd.go#L18 type Provider struct {
kv.Provider `mapstructure:",squash"`
}and the kv provider use template https://github.com/containous/traefik/blob/master/provider/kv/kv.go#L149 and there is no status in the template |
timoreimann
force-pushed
the
document-custom-error-pages-restrictions
branch
from
aa4c929
to
10f1751
Compare
|
@juliens thanks for digging into this. I updated the documentation. Let me know what you think. |
traefiker
force-pushed
the
document-custom-error-pages-restrictions
branch
from
10f1751
to
8284e14
Compare
This encompasses which kinds of providers can embed custom error pages.
ldez
force-pushed
the
document-custom-error-pages-restrictions
branch
from
8284e14
to
46b1772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@containous/traefik PTAL.
In particular, someone with sufficient expertise please acknowledge that custom error pages can really be used with the key/value stores we support.
Refs #2035.