Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes entry points configuration. #2120

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Sep 14, 2017

Description

  • Redirect.Regex: fix invalid value regex
  • Redirect.Regex: RedirectPRegex is now invalid
  • Redirect.EntryPoint: RedirectXEntryPoint is now invalid
  • Redirect.Replacement: RedirectYReplacement is now invalid
  • Create a standard string to bool converter
  • refactor EntryPoints.Set() (split in several functions)
  • add a lot of tests

@traefiker traefiker added this to the 1.4 milestone Sep 14, 2017
@ldez ldez force-pushed the fix/entrypoints-configuration branch 2 times, most recently from 69e4700 to f6a2f1a Compare September 14, 2017 17:22
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex !!

LGTM

@traefiker traefiker merged commit df76cc3 into traefik:v1.4 Sep 15, 2017
@ldez ldez deleted the fix/entrypoints-configuration branch September 15, 2017 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants