Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast in IT and fix some flaky tests #2126

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Fail fast in IT and fix some flaky tests #2126

merged 2 commits into from
Sep 18, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Sep 15, 2017 •
edited
Loading

Description

Now if one test fail all other tests are skipped.

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Sep 15, 2017
@ldez ldez added this to the 1.4 milestone Sep 15, 2017
@ldez ldez changed the title go-check fork and fix some flaky tests Fail fast in IT and fix some flaky tests Sep 15, 2017
@ldez ldez force-pushed the refactor/go-check-fork branch 2 times, most recently from 8990750 to ee55e61 Compare September 16, 2017 14:19
SantoDE
SantoDE approved these changes Sep 17, 2017
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼 Get that speeded up!

juliens
juliens approved these changes Sep 18, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Sep 18, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 2296aab into traefik:v1.4 Sep 18, 2017
@ldez ldez deleted the refactor/go-check-fork branch September 18, 2017 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@SantoDE SantoDE SantoDE approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @SantoDE @emilevauge @traefiker