Manage Headers for the Authentication forwarding. #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
refactor/forward-auth-headers
branch
from
11dc1f1
to
926fed5
Compare
ldez
force-pushed
the
refactor/forward-auth-headers
branch
from
926fed5
to
08ffc09
Compare
ekozan
reviewed
Sep 18, 2017
auth/forward.go
Outdated
| forwardReq.Header.Set(forward.XForwardedPort, xfp) | ||
| } | ||
|
|
||
| if xfh := req.Header.Get(forward.XForwardedHost); xfh != "" { |
There was a problem hiding this comment.
If a client access to admin.domain.local and send the header X-FORWARDED-HOST user.domain.local he can by-pass the auth, no ?
There was a problem hiding this comment.
yes, I added a new option "trustForwardHeader"
ldez
force-pushed
the
refactor/forward-auth-headers
branch
from
657d6ab
to
72b6f3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
X-Forwarded-*headers