Fix SSE subscriptions when retries are enabled #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: a good candidate for an integration test might be https://github.com/thomasleveil/docker-server-sent-events. |
timoreimann
approved these changes
Sep 20, 2017
traefiker
force-pushed
the
fix-SSE-with-retries-enabled
branch
from
e051fcb
to
e95d621
Compare
nmengin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1862. I created a new PR as there was no feedback on #1870 and some implementation details are different, yet the fix is more or less the same.
This fix is already running in our infra for about 2 weeks. I was trying to set up an unit-test, which proved difficult. I am currently thinking about setting up an integration test for this, but that might also prove difficult. Let me know whether you think it is an absolute necessity to have an integration test for that or not.l