Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compression documentation #2184

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

errm
Copy link
Contributor

@errm errm commented Sep 28, 2017

Description

Fixes #2183 where a bug report was filed because it seemed like the compression middleware was not working because it intentionally does not compress small responses.

@ldez
Copy link
Contributor

ldez commented Sep 28, 2017

Could you change the base branch to 1.4?

@errm errm changed the base branch from master to v1.4 September 28, 2017 21:38
@errm errm force-pushed the errm/improve-compression-doc branch from e1ca354 to 1fafd7a Compare September 28, 2017 21:42
@errm
Copy link
Contributor Author

errm commented Sep 28, 2017

Ok @ldez rebased on v1.4

@ldez ldez added this to the 1.4 milestone Sep 28, 2017
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants