Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for urlencoded part in url #2199

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Add tests for urlencoded part in url #2199

merged 1 commit into from
Oct 2, 2017

Conversation

juliens
Copy link
Member

@juliens juliens commented Oct 2, 2017

Add a test to verify urlencoded part in url are not double encoded
fixes #2196

@juliens juliens added this to the 1.4 milestone Oct 2, 2017
ldez
ldez approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 4fe9cc7 into traefik:v1.4 Oct 2, 2017
@traefiker traefiker mentioned this pull request Oct 2, 2017
Closed
@shieldwed shieldwed mentioned this pull request Oct 14, 2017
Closed
@ldez ldez added the kind/enhancement a new or improved feature. label Oct 16, 2017
@juliens juliens deleted the test/websocket-url-encoded branch January 25, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@emilevauge emilevauge emilevauge approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/websocket kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@juliens @ldez @emilevauge @nmengin @traefiker