Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility for sticky #2266

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 14, 2017

Description

if sticky=true -> cookieName="_TRAEFIK_BACKEND"

for new custom cookieName feature:

  • must add stickiness=true
  • add cookieName="MyCookie"

summary:

Options Result
onlystickiness=true activate sticky session and use a 6 chars cookie name (abbrev sha1)
onlysticky=true (deprecated) activate sticky session and use the old cookie name _TRAEFIK_BACKEND
stickiness=true and sticky=true same as stickiness=true
stickiness=true and cookieName=foobar activate sticky session and use foobar as the cookie name
onlycookieName=foobar do nothing
sticky=true and cookieName=foobar same as sticky=true, doesn't use the cookieName value

@MichaelErmer could you retry with this image ldez/traefik:sticky?

Related to #2251, #2238, #2232

@ldez ldez requested review from a team as code owners October 14, 2017 12:29
@traefiker traefiker added this to the 1.4 milestone Oct 14, 2017
@ldez ldez force-pushed the refactor/backward-compatibily-sticky branch 4 times, most recently from edcf94d to 32b6571 Compare October 14, 2017 13:31
@ldez ldez force-pushed the refactor/backward-compatibily-sticky branch 3 times, most recently from 5233713 to eb5bcd8 Compare October 15, 2017 12:12
@ldez ldez changed the title Backward compatibily for sticky Backward compatibility for sticky Oct 15, 2017
@ldez ldez mentioned this pull request Oct 15, 2017
@MichaelErmer
Copy link
Contributor

MichaelErmer commented Oct 15, 2017

Docker Swarm works perfectly now! Thanks a lot @ldez

@lvnilesh
Copy link

Docker Swarm works using ldez/traefik:sticky

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @ldez 👏
LGTM

@gabrielfsousa
Copy link

gabrielfsousa commented Oct 16, 2017

is web gui working ? for me no :(
sorry, this dont work on swarm :(

test run in non service/swarm, and works, and sticky works now

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the refactor/backward-compatibily-sticky branch from 11b08a9 to 2e60d23 Compare October 16, 2017 15:24
@traefiker traefiker merged commit 0850365 into traefik:v1.4 Oct 16, 2017
@ldez ldez deleted the refactor/backward-compatibily-sticky branch October 16, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants