Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex capturing group. #2296

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 20, 2017

Description

Fix the problem is due a breaking change has been added in gorilla/mux#218 and gorilla/mux#185.

Fixes #2272

@emilevauge
Copy link
Member

@ldez I don't see any glide.yaml in the changelog, is it normal? 🤔

@ldez
Copy link
Contributor Author

ldez commented Oct 21, 2017

@emilevauge yes it's normal because I use master

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants