Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed dead link in kubernetes backend config docs #2337

Merged
merged 1 commit into from
Oct 30, 2017
Merged

fixed dead link in kubernetes backend config docs #2337

merged 1 commit into from
Oct 30, 2017

Conversation

perplexa
Copy link
Contributor

title says it all :)

@perplexa perplexa requested a review from a team as a code owner October 27, 2017 10:37
timoreimann
timoreimann approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. 👏

@emilevauge emilevauge added this to the 1.4 milestone Oct 27, 2017
@mmatur
Copy link
Member

mmatur commented Oct 27, 2017 •
edited
Loading

Thanks for your contribution
@perplexa We will integrate your documentation fix into 1.4.

Could you rebase please?

@mmatur mmatur changed the base branch from master to v1.4 October 27, 2017 11:39
ldez
ldez approved these changes Oct 30, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 5292b84 into traefik:v1.4 Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@perplexa @mmatur @timoreimann @ldez @emilevauge @traefiker