Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush and Status code #2403

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Flush and Status code #2403

merged 1 commit into from
Nov 14, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Nov 14, 2017

What does this PR do?

Only flush once startGzip has been called

Motivation

This prevents the underlying Flusher from writing the wrong status code or writing headers before Content-Encoding has been set.

More

  • Added/updated tests

Additional Notes

@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. status/2-needs-review labels Nov 14, 2017
@traefiker traefiker added this to the 1.4 milestone Nov 14, 2017
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1e35068 into traefik:v1.4 Nov 14, 2017
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Nov 14, 2017
@ldez ldez changed the title Flush and errorcode Flush and Status code Nov 14, 2017
@ldez ldez deleted the fix/flush-and-errorcode branch November 14, 2017 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants