Fix panic if listContainers fails…

[vdemeester]

… and also share context accross API call, as this is how it's meant to be used (and it allows to skip some calls if cancel is called).

Fixes #442

/cc @samber @emilevauge

PS: this need a little bit of testing though 👼

Signed-off-by: Vincent Demeester [email protected]

[emilevauge]

@vdemeester entering light speed bug fixing

[vdemeester]

Ok it's green, at least I did not break anything easily detected 😅
But still need some exercices 😸

[emilevauge]

@vdemeester doesn't seem risky to me.
LGTM :)

[samber]

Sharing context seems good but i think it's not enough. What about doing the append(.....) in an else condition in listContainers() ?

for _, container := range containerList {
        containerInspected, err := dockerClient.ContainerInspect(ctx, container.ID)
        if err != nil {
            log.Warnf("Failed to inpsect container %s, error: %s", container.ID, err)
        } else {
            containersInspected = append(containersInspected, containerInspected)
        }
    }

[vdemeester]

@samber oh definitely, I thought it was in the else… I guess I needed a nap today 😃
I'll update 😉

[emilevauge]

@samber OK to merge this one ?

[samber]

yes ;-)