Prioritize kubernetes routes by path length #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philk
force-pushed
the
kubernetes-priorities
branch
from
fdfbf13
to
6fb483d
Compare
|
Thanks @philk :) |
philk
force-pushed
the
kubernetes-priorities
branch
from
6fb483d
to
2791686
Compare
The Kubernetes provider wasn't setting priorities which was causing shorter paths to get chosen before longer ones. This now matches the [documentation](https://github.com/containous/traefik/blob/master/docs/basics.md#priorities)
philk
force-pushed
the
kubernetes-priorities
branch
from
2791686
to
79dd72f
Compare
|
@emilevauge sorry about that, fixed now |
emilevauge
added
status/2-needs-review
and removed
contributor/waiting-for-corrections
labels
|
Thanks! |
|
Good catch, LGTM too |
|
LGTM 👍 |
ldez
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes provider wasn't setting priorities which was causing
shorter paths to get chosen before longer ones. This now matches the
documentation