ACME: renew certificates 30 days before expiry #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is what the official client does it seams reasonable to me... lgtm |
|
ping @containous/traefik |
|
LGTM 🐸 |
|
@JayH5 need a rebase :) |
|
@errm I hope just merging from master is ok? |
|
LGTM |
|
@JayH5 i prefer a rebase on master if you could . . . it keeps the commit history a little nicer. |
JayH5
force-pushed
the
acme-renew-30-days
branch
from
b5e8fda
to
0cac821
Compare
JayH5
force-pushed
the
acme-renew-30-days
branch
from
0cac821
to
1872e2b
Compare
|
@errm done |
ldez
added
area/acme
and removed
status/2-needs-review
contributor/needs-resolve-conflicts
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the official certbot client does.
There are at least a few renewal reminder emails that will be sent by Let's Encrypt if we only renew 7 days before expiry. We can avoid that by renewing sooner.
Using 30 days as the default is a good start, I think, but I'm not sure if/where this should be documented or if it should actually be configurable.