If Marathon doesn't have healthcheck, assume it's ok #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Healthcheck are not mandatory, so if a result is not present, assume it is ok to continue. Fixes the case when a new leader is elected and don't have any healthcheck result's, returning 404 to all requests. #653
|
/cc @containous/traefik |
|
LGTM |
|
@gomes needs a rebase :) |
|
Done |
|
@gomes thanks for this, LGTM :) |
|
@emilevauge done, I had to execute 2 times because of a build failure. |
ldez
added
area/provider/marathon
and removed
contributor/needs-resolve-conflicts
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Healthcheck are not mandatory, so if a result is not present, assume it
is ok to continue. Fixes the case when a new leader is elected and
don't have any healthcheck result's, returning 404 to all requests.
#653