Update docs to improve contribution setup #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
reviewed
Sep 20, 2016
There was a problem hiding this comment.
Thanks a lot @dtomcej :)
Just one small typo before merging.
| - You will want to add those 2 export lines to your `.bashrc` or `.bash_profile` | ||
| - You need `go-bindata` to be able to use `go generate` command (needed to build) : `$ go get github.com/jteeuwen/go-bindata/...` (Please note, the ellipses are required) | ||
|
|
||
| ###### Settig up your `glide` environment |
vdemeester
reviewed
Sep 20, 2016
| `vendor` and add it to your `glide.yaml`. | ||
|
|
||
| ```bash | ||
| $ glide install | ||
| # generate | ||
| # generate (Only required to integrate other components such as web dashboard) |
There was a problem hiding this comment.
Note that the script used inside the docker container still work here, ./script/make.sh binary does both generate and build. I don't think we should mention it but 😝
|
Cool :-) 👍 Maybe just do a quick rebase to squash the second commit? |
|
Ya, Sounds good. Will update the branch too. |
dtomcej
force-pushed
the
update-docs
branch
from
1e8ecfc
to
86e6c46
Compare
silly spelling mistake Document accepted values for logLevel. Add possibility to use BindPort IPAddress 👼 Signed-off-by: Vincent Demeester <[email protected]> Update marathon Signed-off-by: Emile Vauge <[email protected]>
dtomcej
force-pushed
the
update-docs
branch
from
9ffa5bf
to
e5dcfa0
Compare
|
LGTM now :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.