Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show current version in web UI #709

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Conversation

vhf
Copy link
Contributor

@vhf vhf commented Oct 2, 2016

Show traefik version and codename in the web ui, as a link to the tag or commit for this version.

screen shot 2016-10-02 at 20 17 47

I know next to nothing about Angular or Go, please review carefully.

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @vhf, thanks a lot :)
LGTM
ping @ldez

@vdemeester vdemeester added this to the 1.1 milestone Oct 2, 2016
@emilevauge emilevauge changed the base branch from master to v1.1 October 2, 2016 18:32
@emilevauge
Copy link
Member

Tests are failing, you need to go fmt your code, using make fmt.

@vhf
Copy link
Contributor Author

vhf commented Oct 2, 2016

Done :)

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@emilevauge emilevauge merged commit 6632247 into traefik:v1.1 Oct 3, 2016
@vhf vhf deleted the webui-show-version branch December 6, 2017 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants