-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Træfik on docker swarm mode #715
Conversation
7afe973
to
36c7d4c
Compare
Hi, I've tested this docs with the 1.1.0-rc1 and it is not correct. In your examples you are missing the needed labels to let traefik check the services. I've tried this instead with success:
Probably create a PR for this PR does not worth it. ;) |
X-Forwarded-Server: 8fbc39271b4c | ||
``` | ||
|
||
Note that as Træfik is publish, you can access it from any machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is published
``` | ||
|
||
Note that as Træfik is publish, you can access it from any machine | ||
(and not only the manager). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove parenthesis
@@ -1,7 +1,7 @@ | |||
# Swarm cluster | |||
|
|||
This section explains how to create a multi-host [swarm](https://docs.docker.com/swarm) cluster using [docker-machine](https://docs.docker.com/machine/) and how to deploy Træfɪk on it. | |||
The cluster will be made of: | |||
The cluster is be made of: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cluster consists of
on a manager node. | ||
- `--mount type=bind,source=/var/run/docker.sock,target=/var/run/docker.sock`: | ||
we bind mount the docker socket where Træfik is scheduled to be able | ||
to speak to him. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to speak to the docker daemon
It would be nice to have 2 separate networks for the |
36c7d4c
to
6d02892
Compare
@ralphtheninja thanks 👼 @bvis Yes, I forgot @weitzj I definitely went for the simplest example ever here 😅. We could enhance the documentation with multiple network (one for each app served) and a way to update the |
d6f8fdc
to
2acef27
Compare
Needs a rebase :) |
37eb96d
to
c98b416
Compare
Also small update on the swarm one. Signed-off-by: Vincent Demeester <[email protected]>
c98b416
to
3692e1c
Compare
Unless I am mistaken there is a slight error with how the placement contraint is declared, the official syntax is |
@tlvenn both should work the same 👼 |
Ya I didnt check but figured it would however I believe it would be a little bit better to stick with the official syntax, especially given that's the one you are already using for the other options ;) Anyway, I am nitpicking, thanks in any case, for putting the doc together. |
😝 |
One new question, did you investigate the
Should we update the doc to reflect that ? |
Make a PR and lets discuss that instead ;) |
Well there is no point to create a PR if we dont even agree it should be amended... In the end, there are 3 choices:
In case we choose 2 or 3, I am happy to create the PR. |
One last comment, for security purpose, the docker socket should really be mounted in read only mode so that in the unlikely event the container is compromised, it does not mean the whole cluster has been taken over... |
Still a little bit work in progress, I need to add output of commands 👼.
Also small update on the swarm one.
/cc @containous/traefik
🐸
Signed-off-by: Vincent Demeester [email protected]