Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix networkMap construction in ListServices #724

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Fix networkMap construction in ListServices #724

merged 1 commit into from
Oct 10, 2016

Conversation

vincentlepot
Copy link

This PR fixes #719

The problem is due to a moving pointer reference. The networkMap lists network IDs all with the same network information.

@vdemeester vdemeester changed the base branch from master to v1.1 October 7, 2016 14:41
@vdemeester vdemeester added this to the 1.1 milestone Oct 7, 2016
@vdemeester
Copy link
Contributor

@vincentlepot could you rebase on the v1.1 branches 👼 (we'll merge it back to master after the release)

@vincentlepot
Copy link
Author

Rebase done

vdemeester
vdemeester approved these changes Oct 7, 2016
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸
/cc @containous/traefik

emilevauge
emilevauge approved these changes Oct 10, 2016
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentlepot :)
LGTM

@emilevauge emilevauge merged commit d3f79c7 into traefik:v1.1 Oct 10, 2016
@vincentlepot vincentlepot deleted the fix_network_label_service branch June 14, 2017 12:20
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@vincentlepot @vdemeester @emilevauge @ldez