Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that we serve HTTP/2 #820

Merged
merged 1 commit into from
Nov 14, 2016
Merged

Check that we serve HTTP/2 #820

merged 1 commit into from
Nov 14, 2016

Conversation

trecloux
Copy link
Contributor

@trecloux trecloux commented Nov 9, 2016

To be sure that bug #790 fixed in #814 does not come back

@emilevauge emilevauge changed the base branch from master to v1.1 November 9, 2016 20:47
@emilevauge emilevauge changed the base branch from v1.1 to master November 9, 2016 20:47
@errm
Copy link
Contributor

errm commented Nov 11, 2016

this test seems to be failing on CI

----------------------------------------------------------------------
FAIL: https_test.go:22: HTTPSSuite.TestWithSNIConfigHandshake
https_test.go:47:
    c.Assert(proto, checker.Equals, "h2")
... obtained string = ""
... expected string = "h2"
---------------------------------------------------------------------

was it working for you locally @trecloux?

@trecloux trecloux force-pushed the check_http2 branch 2 times, most recently from 1641ca9 to 24905d2 Compare November 11, 2016 16:49
@trecloux trecloux changed the base branch from master to v1.1 November 11, 2016 16:50
@trecloux
Copy link
Contributor Author

@errm The tests were running based on master branch and the test is failing because master branch does not include the fix to server HTTP/2 (#814).
I modified the pull request to be based on v1.1.

errm
errm approved these changes Nov 13, 2016
View reviewed changes
Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@errm
Copy link
Contributor

errm commented Nov 13, 2016

ping @containous/traefik

@SantoDE
Copy link
Collaborator

SantoDE commented Nov 13, 2016

LGTM 👼

@vdemeester
Copy link
Contributor

@trecloux needs a rebase 😓

@emilevauge emilevauge added this to the 1.1 milestone Nov 14, 2016
@trecloux
Copy link
Contributor Author

@vdemeester Rebase done

emilevauge
emilevauge approved these changes Nov 14, 2016
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @trecloux

@emilevauge emilevauge merged commit c26b36c into traefik:v1.1 Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

@errm errm errm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@trecloux @errm @SantoDE @vdemeester @emilevauge @ldez