Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Version, Codename and Date to crosscompiled #842

Merged
merged 1 commit into from
Nov 14, 2016
Merged

Pass Version, Codename and Date to crosscompiled #842

merged 1 commit into from
Nov 14, 2016

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Nov 14, 2016

Copy variables from ./script/binary

Version:      dev
Codename:     cheddar
Go version:   go1.7.3
Built:        I don't remember exactly
OS/Arch:      linux/amd64

to

Version:      v1.1.0-rc4
Codename:     camembert
Go version:   go1.7.3
Built:        2016-11-10_11:29:24AM
OS/Arch:      linux/amd64

@emilevauge emilevauge changed the base branch from master to v1.1 November 14, 2016 15:37
@emilevauge emilevauge changed the base branch from v1.1 to master November 14, 2016 15:38
@emilevauge
Copy link
Member

emilevauge commented Nov 14, 2016 •
edited
Loading

Oops! Thanks @guilhem ! Is it possible to create this PR on v1.1 branch (so that we get this fixed in v1.1 version) ?

@guilhem guilhem changed the base branch from master to v1.1 November 14, 2016 15:41
@guilhem
Pass Version, Codename and Date to crosscompiled
d3b48cd 
Copy variables from ./script/binary
@guilhem
Copy link
Contributor Author

guilhem commented Nov 14, 2016

@emilevauge done

emilevauge
emilevauge approved these changes Nov 14, 2016
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
LGTM
/cc @containous/traefik

@emilevauge emilevauge added this to the 1.1 milestone Nov 14, 2016
vdemeester
vdemeester approved these changes Nov 14, 2016
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit f6576cc into traefik:v1.1 Nov 14, 2016
@guilhem guilhem deleted the version-cross-binary branch November 14, 2016 16:45
@MaxMood96 MaxMood96 mentioned this pull request Nov 5, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@guilhem @emilevauge @vdemeester @ldez