Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize backend even if is user-defined #865

Merged
merged 2 commits into from
Nov 23, 2016
Merged

Normalize backend even if is user-defined #865

merged 2 commits into from
Nov 23, 2016

Conversation

WTFKr0
Copy link
Contributor

@WTFKr0 WTFKr0 commented Nov 21, 2016

Signed-off-by: WTFKr0 [email protected]

@WTFKr0
Copy link
Contributor Author

WTFKr0 commented Nov 21, 2016

Hi,

This pull request to normalize user defined backend by label.
I have an automatic labelling process so the label is a version like : myapp-1.0.2
Traefik backends don't like the dots

Are you OK with that ?

@emilevauge
Copy link
Member

Thanks @WTFKr0!
@containous/traefik, shouldn't we push this on branch v1.1 instead?

@vdemeester
Copy link
Contributor

The diff is not that big of a deal so yeah, we could put it into a 1.1.1 😇
LGTM 🐸

@emilevauge
Copy link
Member

@WTFKr0 could you change the base of this PR to branch v1.1 please?

@WTFKr0 WTFKr0 changed the base branch from master to v1.1 November 22, 2016 19:40
@emilevauge
Copy link
Member

@WTFKr0 I'm sorry but you will have to rebase your PR. There are too much commits here ^^

@WTFKr0
Copy link
Contributor Author

WTFKr0 commented Nov 23, 2016

Don't know how to that... :/
Should i create new PR ?

@WTFKr0
Copy link
Contributor Author

WTFKr0 commented Nov 23, 2016

Or is it something like :
git fetch origin
git rebase origin/v1.1
?

@emilevauge
Copy link
Member

Create a new local branch from v1.1 and push force to Github. Or create a new pr if you prefer :)

@WTFKr0
Copy link
Contributor Author

WTFKr0 commented Nov 23, 2016

I think it's OK now !!
#Galère

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM 😉

@emilevauge emilevauge merged commit 2bf9acd into traefik:v1.1 Nov 23, 2016
emilevauge pushed a commit that referenced this pull request Dec 5, 2016
@WTFKr0 WTFKr0 deleted the normalize-backend-docker branch January 4, 2017 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants