Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml zookeeper doc fix #948

Merged
merged 4 commits into from
Dec 20, 2016
Merged

toml zookeeper doc fix #948

merged 4 commits into from
Dec 20, 2016

Conversation

rdrgmnzs
Copy link
Contributor

@rdrgmnzs rdrgmnzs commented Dec 8, 2016 •
edited by emilevauge
Loading

Having that slash there causes traefik to be able to get keys from ZK

@rdrgmnzs
toml zookeeper doc fix
b6358fa 
Having that slash there causes traefik to be able to get keys from ZK
emilevauge
emilevauge approved these changes Dec 14, 2016
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brdude
LGTM

@SantoDE
Copy link
Collaborator

SantoDE commented Dec 19, 2016

LGTM 👼

Need's a rebase tough :)

@emilevauge emilevauge merged commit 6b20d2a into traefik:master Dec 20, 2016
@ldez ldez added this to the 1.2 milestone Oct 1, 2017
@eubnara eubnara mentioned this pull request Dec 16, 2017
Closed
@ldez ldez mentioned this pull request Dec 16, 2017
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/zk
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@rdrgmnzs @SantoDE @emilevauge @ldez