Add ACME/Let’s Encrypt integration tests #975
Conversation
trecloux
force-pushed
the
integration-test-acme
branch
from
37f9800
to
31719a0
Compare
| BaseSuite | ||
| } | ||
|
|
||
| func (s *AcmeSuite) setupBoulder(c *check.C) { |
There was a problem hiding this comment.
This could be in SetUpSuite and not called by the test I think 👼
There was a problem hiding this comment.
I used the same structure than the ConsulSuite, but yes sounds good :-)
| @@ -52,6 +54,18 @@ func (s *BaseSuite) TearDownSuite(c *check.C) { | |||
| func (s *BaseSuite) createComposeProject(c *check.C, name string) { | |||
| projectName := fmt.Sprintf("integration-test-%s", name) | |||
| composeFile := fmt.Sprintf("resources/compose/%s.yml", name) | |||
|
|
|||
| addrs, err := net.InterfaceAddrs() | |||
There was a problem hiding this comment.
@trecloux care to explain this change ? 👼
There was a problem hiding this comment.
The ACME/Boulder service needs to call traefik to check the HTTPS/SNI challenge.
So we need to know the IP address of traefik.
This code is looking for the host non loopback IP V4 address .
There was a problem hiding this comment.
Hum ok, but who uses DOCKER_HOST_IP ?
There was a problem hiding this comment.
ah nevermind, didn't look at the compose file 😂
trecloux
force-pushed
the
integration-test-acme
branch
from
476d31d
to
fcd0a2f
Compare
| @@ -0,0 +1,44 @@ | |||
| boulder: | |||
| image: trecloux/boulder:20161209-8a6382f4 | |||
There was a problem hiding this comment.
What changes have been made to letsencrypt/boulder?
There was a problem hiding this comment.
No change, I just built/pushed the last commit of the release branch 8a6382f4 is the commit id. The official image was not updated for 9 months.
trecloux
force-pushed
the
integration-test-acme
branch
from
fcd0a2f
to
c797162
Compare
|
@trecloux If you don't mind, could you use this image instead: |
trecloux
force-pushed
the
integration-test-acme
branch
from
802616d
to
6d37e15
Compare
|
@emilevauge I updated the image. Unfortunately the test looks instable on travis |
| } | ||
| return nil | ||
| }) | ||
|
|
There was a problem hiding this comment.
You should add c.Assert(err, checker.IsNil) here I think ;)
|
@emilevauge Thanks for the tip, fixed it. |
trecloux
force-pushed
the
integration-test-acme
branch
from
7b0e29a
to
7f5190c
Compare
|
@vdemeester I rebased the branch, should I squash the commits ? |
In this case yeah, we don't need to keep |
Thx @gwallet for the help.
trecloux
force-pushed
the
integration-test-acme
branch
from
7f5190c
to
599c95e
Compare
ldez
added
status/3-needs-merge
area/acme
and removed
status/2-needs-review
status/1-needs-design-review
labels
Tests are based on a boulder image I pushed on my personal docker hub account.
Thx @gwallet for the help.