fix: include typings in the release #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jwhiles
approved these changes
May 11, 2021
| @@ -18,7 +18,7 @@ export interface CollectionResponse<T> { | |||
| sys: { type: string } | |||
| } | |||
|
|
|||
| export type ContentEntityType = 'Entry' | 'Asset' | |||
| export type ContentEntityType = 'Entry' | 'Asset' | string | |||
There was a problem hiding this comment.
Same as above: somewhere we use constant strings to address the Entity type, sometimes we use just string. Once types in CMA are fixed this can go back to a list of constant strings
andipaetzold
approved these changes
May 11, 2021
ghost
pushed a commit
that referenced
this pull request
May 11, 2021
# [4.0.0-alpha.2](v4.0.0-alpha.1...v4.0.0-alpha.2) (2021-05-11) ### Bug Fixes * include typings in the release ([#699](#699)) ([16b15e2](16b15e2))
|
🎉 This PR is included in version 4.0.0-alpha.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
ghost
added
the
loweisz
pushed a commit
that referenced
this pull request
Jun 30, 2021
* fix: include typings in the release * chore: tweak space api types to adhere to cma.js * refactor: Item -> Items * revert: old tags api * feat: export UserAPI
loweisz
pushed a commit
that referenced
this pull request
Jun 30, 2021
# [4.0.0-alpha.2](v4.0.0-alpha.1...v4.0.0-alpha.2) (2021-05-11) ### Bug Fixes * include typings in the release ([#699](#699)) ([16b15e2](16b15e2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.