feat: test that SDK respects alias #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jwhiles
commented
May 14, 2021
andipaetzold
approved these changes
May 14, 2021
Jwhiles
added a commit
that referenced
this pull request
May 14, 2021
* feat: create an alias before running tests * feat: alias id test * feat: try to make it fail * Revert "feat: try to make it fail" This reverts commit 8a0539f. * feat: wait till env is ready to make alias * Revert "Revert "feat: try to make it fail"" This reverts commit f2e13e0. * Revert "Revert "Revert "feat: try to make it fail""" This reverts commit 6de184d. * feat: add extra assertion * chore: pass alias id
loweisz
added a commit
that referenced
this pull request
May 18, 2021
ghost
pushed a commit
that referenced
this pull request
May 18, 2021
loweisz
pushed a commit
that referenced
this pull request
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for the entry editor location to make sure the SDK is hitting the correct endpoints in aliased environments.
If we're happy with this approach, we might want to add similar tests for each SDK/location as a follow up