feat: [] add cma adapter to sdk #816
Conversation
Change stale limit to 2 hours instead of 1 day
To prevent some flaky integration tests failing when reaching the rate limit on visiting the entry, this adds a command to visit entries and when failed with a 429 it waits 1second and revisits the page.
| @@ -47,6 +48,7 @@ function makeSharedAPI(channel: Channel, data: ConnectMessage): BaseExtensionSDK | |||
| const currentLocation = data.location || locations.LOCATION_ENTRY_FIELD | |||
|
|
|||
| return { | |||
| cmaAdapter: createAdapter(channel), | |||
There was a problem hiding this comment.
We were originally planning to just call this adapter - right?
There was a problem hiding this comment.
Yes, we thought the name adapter is a little generic and therefore went for cmaAdapter in case there will be more adapters in the future (e.g. GraphQL adapter?).
Also, the name anyway doesn't match with the cma.js as it needs to passed in there as apiAdapter
lib/types.ts
Outdated
| @@ -705,6 +707,8 @@ export interface BaseExtensionSDK { | |||
| access: AccessAPI | |||
| /** Exposes relevant ids, keys may be ommited based on location */ | |||
| ids: IdsAPI | |||
| /** the adapter that can be used for creating the cma client */ | |||
There was a problem hiding this comment.
Not sure this comment is correct, the adapter is already created at the time we create the SDK, right?
There was a problem hiding this comment.
Yes, the adapter is created, but the comment says that you can use it to create the cma client, or did I word that wrong?🤔.
There was a problem hiding this comment.
The comment is correct but still should be reworded to be consistent with the other comments
There was a problem hiding this comment.
Updated the commment
# Conflicts: # CHANGELOG.md # lib/types.ts # package-lock.json # package.json
# [4.0.0-alpha.19](v4.0.0-alpha.18...v4.0.0-alpha.19) (2021-07-01) ### Features * [] add cma adapter to sdk ([#816](#816)) ([24dab4e](24dab4e))
|
🎉 This PR is included in version 4.0.0-alpha.19 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
ghost
added
the
Purpose of PR
PR Checklist