Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [] update create contentType function with optional id #859

Merged
merged 8 commits into from
Jul 23, 2021

Conversation

loweisz
Copy link
Contributor

@loweisz loweisz commented Jul 14, 2021

The id will be generated automatically when not passed so we can make it optional.

PR Checklist

  • Tests are added/updated/not required
  • Tests are passing
  • Typescript typings are added/updated/not required

@loweisz loweisz requested a review from a team as a code owner July 14, 2021 15:03
@loweisz loweisz changed the base branch from master to canary July 14, 2021 15:03
@andipaetzold andipaetzold changed the title Fix: [] update create contentType function with optional id fix: [] update create contentType function with optional id Jul 15, 2021
@loweisz loweisz changed the base branch from canary to master July 16, 2021 08:58
@loweisz loweisz changed the base branch from master to canary July 16, 2021 08:59
Copy link
Contributor

@andipaetzold andipaetzold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert package-lock.json and run npm install with npm 6

@loweisz loweisz merged commit 8d1f562 into canary Jul 23, 2021
@loweisz loweisz deleted the fix-createContenttype-with-optional-id branch July 23, 2021 14:42
ghost pushed a commit that referenced this pull request Jul 23, 2021
# [4.0.0-alpha.29](v4.0.0-alpha.28...v4.0.0-alpha.29) (2021-07-23)

### Bug Fixes

* [] update create contentType function with optional id ([#859](#859)) ([8d1f562](8d1f562))
@ghost
Copy link

ghost commented Jul 23, 2021

🎉 This PR is included in version 4.0.0-alpha.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released on @canary label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants