Skip to content
This repository has been archived by the owner on Feb 5, 2018. It is now read-only.

crash when trying to commit #16

Closed
mramato opened this issue Jan 26, 2016 · 3 comments
Closed

crash when trying to commit #16

mramato opened this issue Jan 26, 2016 · 3 comments

Comments

@mramato
Copy link

mramato commented Jan 26, 2016

Originally discussed in karma-runner/karma#1816 but they suggested I open an issue here.

Whenever I try to commit to the karma repository (or rather my fork of it), validate-commit-msg crashes with the following error:

C:\Git\mramato\karma\node_modules\validate-commit-msg\index.js:103
      return buffer.toString().split('\n').shift();
                   ^

TypeError: Cannot read property 'toString' of undefined
    at firstLineFromBuffer (C:\Git\mramato\karma\node_modules\validate-commit-msg\index.js:103:20)
    at ReadFileContext.callback (C:\Git\mramato\karma\node_modules\validate-commit-msg\index.js:92:15)
    at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:303:13)

This happens when the commit message is valid.

Here are my system specs:
Windows 7
Node 4.2.x LTS
Git version 2.6.2.windows.1

Let me know if there's any other information you need or anything I can do to help track down the issue. Thanks.

@kentcdodds
Copy link
Collaborator

I need to give you an apology. For some reason, I want watching this repository so I want getting notifications about issues and pull requests. I am so incredibly sorry. Please forgive me. I really feel awful. I hope my unresponsiveness doesn't hinder you contributing more in the future.

As for your specific pull request, I'll give it a closer look soon.

@kentcdodds
Copy link
Collaborator

This should be fixed by #10 Let me know if it's not.

@mramato
Copy link
Author

mramato commented Feb 2, 2016

Awesome, thanks. There's no need to apologize, I know maintaining an OSS project is anything but easy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants